This commit is contained in:
Lordmau5 2023-11-14 23:32:01 +01:00
parent 42344db22f
commit dcfc55f2b0
4 changed files with 17 additions and 14 deletions

View File

@ -76,6 +76,8 @@ module.exports = {
'@stylistic/lines-around-comment': [
'error',
{
allowBlockStart: true,
allowBlockEnd: true,
beforeBlockComment: true
}
],

View File

@ -35,7 +35,7 @@
"@vue/eslint-config-typescript": "^12.0.0",
"@vue/test-utils": "^2.4.1",
"@vue/tsconfig": "^0.4.0",
"eslint": "^8.49.0",
"eslint": "^8.53.0",
"eslint-plugin-vue": "^9.17.0",
"jsdom": "^22.1.0",
"npm-run-all2": "^6.1.1",

2
pnpm-lock.yaml generated
View File

@ -71,7 +71,7 @@ devDependencies:
specifier: ^0.4.0
version: 0.4.0
eslint:
specifier: ^8.49.0
specifier: ^8.53.0
version: 8.53.0
eslint-plugin-vue:
specifier: ^9.17.0

View File

@ -56,18 +56,19 @@ export class BingoGame {
}
addGroup(group: BingoGroup): void {
// TODO: Right now we can do circular groups.
// 1.parent = 2, 2.parent = 1
// This will loop the objects infinitely.
// Make sure that going through the tree we don't have this problem.
//
// Option B:
// Trash idea of groups-in-groups (parent system)
// Just have groups and be done with them.
//
// Option C:
// Bring back categories so we have categories + groups.
// _____________________________________________________
/*
* TODO: Right now we can do circular groups.
* 1.parent = 2, 2.parent = 1
* This will loop the objects infinitely.
* Make sure that going through the tree we don't have this problem.
*
* Option B:
* Trash idea of groups-in-groups (parent system)
* Just have groups and be done with them.
*
* Option C:
* Bring back categories so we have categories + groups.
*/
if (this.groups.some(_group => stringCompare(_group.name, group.name)))
return;